Do you mean if your custom plugin points to some other database, then our build-in plugins will point to that one instead of the default one?
Actually I think in this case it can cause other issues with other parts of the code where dataSettingsManager.LoadSettings() is used. For example, in \Nop.Web.Framework\Infrastructure\DependencyRegistrar.cs
So maybe, it's better to revert back these changes and leave it for plugin customization
Do you mean if your custom plugin points to some other database, then our build-in plugins will point to that one instead of the default one?
yes
please leave the changeset as is, it works with the suggestion above. the thing is datasettings holds the last settings which is the plugin and in order to set it back to default the reloadSettings must be true.
Right. We don't want to reload settings for built-in plugins (pass "reloadSettings" to "true").
I meant other point. "dataSettingsManager.LoadSettings()" can be invoked not only by plugins by other code (e.g. in \Nop.Web.Framework\Infrastructure\DependencyRegistrar.cs file). So it's better to leave for customization (at least now) so it doesn't cause issues for other developers
This topic was automatically closed 365 days after the last reply. New replies are no longer allowed.