nopCommerce 4.00 BETA released. Please share your impressions
- 36
- 426
- 6/12/2014
- United Kingdom
Nice work guys.
Slightly off topic but I notice that in this release the azure picture service is using async calls however the calling function uses ".Result" which will in effect block and cause the call to be synchronous. All database access is also still synchronous.
So this release will speed things up by reducing the time spent in the http request cycle but I don't see it helping much with concurrent user load if you are using sql azure or if you store pictures in azure blob. Switching everything to async in my mind will provide much better performance and scalability benefits than just switching to .net core, you could also start using async viewcomponents as I imagine adding widgets is a big factor in slowing a site down.
https://news.ycombinator.com/item?id=13383016
Slightly off topic but I notice that in this release the azure picture service is using async calls however the calling function uses ".Result" which will in effect block and cause the call to be synchronous. All database access is also still synchronous.
So this release will speed things up by reducing the time spent in the http request cycle but I don't see it helping much with concurrent user load if you are using sql azure or if you store pictures in azure blob. Switching everything to async in my mind will provide much better performance and scalability benefits than just switching to .net core, you could also start using async viewcomponents as I imagine adding widgets is a big factor in slowing a site down.
https://news.ycombinator.com/item?id=13383016
- 4
- 20
- 9/22/2016
- United States
I downloaded 4.00 BETA version, and tried to install it. First time I entered all the necessary data on the set up page. And it quits quietly. Then tried to run it second time, got this error:
https://www.dropbox.com/s/ojtjk8bw9h8tzf5/NopLoadError.png?dl=0
Tried to debug the code, and it brought up NopCommerce 4.0 BETA successfully. Tested 10 times without debugging, and about 3 times it fails to start. I am using Visual Studio 2017 Professional. It seems like there is a race condition in loading data. We may need put a delay in the code below:
public virtual IList<ScheduleTask> GetAllTasks(bool showHidden = false)
{
var query = _taskRepository.Table;
Thread.Sleep(2000); //Delay 1 second, it fails 3 times in 10 tries. Delay 2 seconds it fails 1 time in 10 tries.
if (!showHidden)
{
query = query.Where(t => t.Enabled);
}
query = query.OrderByDescending(t => t.Seconds);
var tasks = query.ToList();
return tasks;
}
https://www.dropbox.com/s/ojtjk8bw9h8tzf5/NopLoadError.png?dl=0
Tried to debug the code, and it brought up NopCommerce 4.0 BETA successfully. Tested 10 times without debugging, and about 3 times it fails to start. I am using Visual Studio 2017 Professional. It seems like there is a race condition in loading data. We may need put a delay in the code below:
public virtual IList<ScheduleTask> GetAllTasks(bool showHidden = false)
{
var query = _taskRepository.Table;
Thread.Sleep(2000); //Delay 1 second, it fails 3 times in 10 tries. Delay 2 seconds it fails 1 time in 10 tries.
if (!showHidden)
{
query = query.Where(t => t.Enabled);
}
query = query.OrderByDescending(t => t.Seconds);
var tasks = query.ToList();
return tasks;
}
