Find bugs in nopCommerce 4.00 BETA and earn $10

Hard coded text in Customer edit page.

Text: Some comment here...

screen shot:
https://ibb.co/jZBjRR

Hard coded text in kendo grid

text: Save changes
text: Cancel changes

a character space required in product tag edit page.

screen shot:
https://ibb.co/iQNf0m

bakbuz wrote:
You're absolutely right. Fixed

bakbuz wrote:
Thanks again. Fixed

bakbuz wrote:
Although we don't consider non-localizable strings as bugs, thanks a lot anyway.Here is a work item

bakbuz wrote:
Thanks. But already reported

bakbuz wrote:
And the third confirmed issue. Fixed. Good job! Thanks a lot!

Hi,

We believe there is a bug introduced in v4.00.
Customer is unable to login if customer is created from Admin when CustomerSetting.UsernameEnabled is set to false.

Steps to Reproduce:
1. Set UsernamesEnabled as false in Settings -> customer Settings.
2. Create new customer from Admin area.
3. Try to login from customer area with this new user's email.

Actual Result:
User is unable to login and the page ends up to exception.

Reason:
When customer is created from admin area, username field is left 'null' which in turn ends to null exception while creating claim in CookieAuthenticationService.SignIn(Customer customer, bool isPersistent)

Solution:
In '..\Presentation\Nop.Web\Areas\Admin\Controllers\CustomerController.cs'
'Create' Post action near Line 900 where Customer object is created the username should be set to model.Email if UsernameEnabled is false else it should be model.Username

Username = _customerSettings.UsernamesEnabled ? model.Username : model.Email

Hope this helps.

Best Regards,
Atluz Nop Team

atluz.com wrote:
Thanks a lot for reporting. You're right. We'll fix it soon