Bug in 4.0 beta, plugin deletion

This topic was automatically closed 365 days after the last reply. New replies are no longer allowed.
6 years ago
We should use this

if(pluginDescriptor.OriginalAssemblyFile.Directory.Exists)
    CommonHelper.DeleteDirectory(pluginDescriptor.OriginalAssemblyFile.DirectoryName);

instead of this

if(pluginDescriptor.OriginalAssemblyFile.Directory.Exists)
    CommonHelper.DeleteDirectory(pluginDescriptor.OriginalAssemblyFile.FullName);


according to https://msdn.microsoft.com/en-us/library/c1sez4sc(v=vs.110).aspx

since the current code gives this error "The specified path is invalid"

It is in pluginmanager.cs line 821
6 years ago
Since the DeleteDirectory funtion uses Directory.GetDirectories(path), we need to pass the folder path and not the path to the file in the folder.
6 years ago
Yes, you are right, I fixed this issue, thank you for your help. Please see this commit for more details
This topic was automatically closed 365 days after the last reply. New replies are no longer allowed.