Shipping Tax design flaw? We are having a huge problem here!

If the built in logic doesn't work for you, you can always create a plugin to override the settings. I recently had to create our own tax provider plugin to calculate taxes correctly in the US, for products and services and for which states needed the shipping/freight tax.

The fault is not in a plugin, otherwise I would make a copy of existing one and did modifications. There needs to be a change in the core product to expose currently private _taxSettings member because likely that defect originated from that member not being public.

I would expect core things like shipping taxation to be fixed by nopCommerce team. The more I change their code the more pain it will be to upgrade to a new version.

I don't know if this post helps but please take a look https://www.nopcommerce.com/boards/t/49755/tax-bug-calculation-for-product-checkout-total.aspx

Thank you for stepping in scoo-b.
The problem in that article is concerned with different products being taxed or not.

The problem we are facing is concerned with Shipping tax calculation being made based on Products setting instead of Shipping setting.

NickBCom wrote:

Logic for the settings in NopCommerce is correct. The place you should be looking is CalculatePrice() because all the prices end up being calculated in this method, and the tax settings somehow mess up calculations here.

I did my debugging and see where the calculation goes wrong. I just want the nopCommerce  team to do the fix themselves otherwise either my fix disappears during next upgrade or I need to repeat it over and over or they change the code completely and all that "fun" will have to start over.

I am also not comfortable poking in the system I did not design as it may result in unintended consequences. I am yet to have a solid business case to learn that software inside-out. I raised this a not so small defect a month ago and have not seen even a reply from nopCommerce team, leave along any fix. Taking more nopCommerce projects is exposing my business to more risks.

Did you have the setting TaxSettings.ShippingTaxClassId set to GST (In my case id = 2) ?

A Tax Invoice just needs to show the GST Tax as a seperate item
There is no specification that an Invoice has to show Tax Inclusive Prices
I just checked a purchase with the settings

Name          Value  
TaxSettings.ShippingIsTaxable    True  
TaxSettings.ShippingPriceIncludesTax  True  
TaxSettings.ShippingTaxClassId    2  (i.e. GST @ 10%)

Item is $9.00 (Excl Tax) Shipping is $1.10 (Inc Tax)

Shopping Cart Shows

Sub-Total:      $9.00
Shipping: (Ground) $1.00
Tax:       $1.00
Total:      $11.00

So nop v4 is correct given the above

If you did want to display Tax Inclusive Prices
Then a simple modification in the shopping cart totals would be to just change the display - not the calculation

i.e. Display

Sub-Total: $9.00 + Tax $0.90 = $9.90
Shipping: (Ground) $1.00 + Tax $0.10 = $1.10
GST Tax Total: $1.00
Total Payable:  $11.00