nopCommerce 4.10 - Bug fixes and improvements

Hi nopCommerce team/community,

We are very excited about the upcoming version of nopCommerce 4.10 - moving to .NET Core 2.1 is a huge step forward for nopCommerce.

But as every new release there are issues that need to be fixed before the actual release.
That is why we would like to open this thread (similar to this one for nopCommerce 4.00) to keep all our feedback for nopCommerce 4.10 in one place.
So we will post anything we find that is a bug, could be improved or is still missing in nopCommerce 4.10 in this thread in a separate post.

Keep up the good work guys!

Thanks,
Boyko

Hello Andrei.

In this commit:
"#2115 Implemented showing vendor name on the shopping cart and order details page"

it seems that only the <th> and <td> elements have been added to the Order Summary table and the table on Order Details page, but the required <col> element is missing.

Depending on table content, this may cause the table layout to break apart.
Please add the required <col> elements too. The two files in question are:

Shared\Components\OrderSummary\Default.cshtml

Order\Details.cshtml


Thanks a lot
/ Hristo

https://www.nopcommerce.com/boards/t/49851/serious-iis-application-pool-recycling-bugdesign-flaw.aspx

This is still a serious problem for 4.0 and all production sites on azure using web apps. Is it fixed in 4.1? If so, please hotfix 4.0. Recycling and shadow copying seems to be the problem.

Other than that, we are really looking forward to 4.1, and the possibility to develop on mac for our frontend coders. We are also looking forward to even better performance.

Here's what I would like to see fixed -

When you make changes to your theme's style.css file, NopCommerce will generate a new bundled CSS with the exact same name as the old one. Because of the way browsers cache CSS files, this means your users are left with an old version of your styles until they hard-refresh.

It seems NopCommerce will only use a new name for the bundled CSS if you change the name of your styles.css, so my workaround has been to change the styles.css filename every time I make changes - eg.. styles1.css, styles2.css, styles3.css

timmit wrote:

In dotnet core you can use append-version on styles, which will add a string to the url for the stylesheet. This way users will always get the latest version.

And will that work with NopCommerces bundling/minification?

timmit wrote:
No idea, but nopcommerce should implement it

This wouldn't be hard to do at all. All you really need to do is change one line in the file "PageHeadBuilder.cs" in the "UI" folder in "Nop.Web.Framework". Line 604 is where it creates the bundle text.

What you could do is change this part of the line:

urlHelper.Content("~/bundles/" + outputFileName + ".min.css"), MimeTypes.TextCss)

To this:

urlHelper.Content("~/bundles/" + outputFileName + ".min.css?" + (new Random()).Next()), MimeTypes.TextCss)

and then it would create a random number attached to the end of the file's name, which will force the browser to download a new version every time. I've done something like this before on a project with often updated .js files so the client could get the latest version and see the changes.


timmit wrote:

bfranklin825 wrote:

That is a terrible idea, this would result in users downloading a brand new bundle every time they load the page. I don't want to bypass stylesheet caching altogether, I just want to prevent users from being stuck with stale stylesheets.

To anybody else who has any bright ideas on how to do this - please don't post them here. Start a new thread. This thread is a great idea, and I don't want to hijack it with discussion about one single issue. I've already outlined the issue and what causes it, nothing more needs to be said on the matter.

Hi guys,

I agree with you but let's keep this forum thread with problems in nopCommerce 4.10 only.
If everyone starts complaining for various issues in nopCommmerce 4.0 this forum thread will loose its main purpose and no one is going to read them and pay attention to the actual issue being reported.
I appreciate your time to write about a problem but let's first try to reproduce a certain issue in the latest nopCommerce 4.10 version and then report it here otherwise please use other forum threads.

Thanks,
Boyko