nopCommerce 4.10 - Bug fixes and improvements

Hello nopCommerce and thank you for paying attention to our suggestions so far.

At the moment, there are a couple of things about the new rating functionalities on product reviews pages that can improved.

First, there is this hidden input element that uses the new HTML5 "hidden" attribute (hidden="hidden"). Please keep in mind that this attribute will not going to work in IE9 and IE10 browsers which nopCommerce still supports. In those browsers the element will go visible. Of course if nopCommerce is about to drop support for IE9 and 10, then this won't be an actual problem.

Another one. You have changed the rating elements markup from a html list layout (<ul>...</ul>) to a division layout (<div>...</div>), which is a good thing in this case. The problem is, that all the elements are now placed on the same html level, there is no wrapping element that separates the rating from the name. Also for any additional rating elements, the <label> element is missing and the name is rendered as unwrapped text, which is against the general logic of form elements in nopCommerce.
Please consider to improve these sections, by changing the markup to something like this for the main rating:

<div class="review-rating">
    <div class="name-description"> 
        <label asp-for="AddProductReview.Rating" asp-postfix=":"></label>
    </div>
    <div class="rating-wrapper">
        <div class="label first">@T("Reviews.Fields.Rating.Bad")</div>
        <div class="rating-options">
            ...
        </div>
        <div class="label last">@T("Reviews.Fields.Rating.Excellent")</div>
    </div>
</div>

and like this for the additional ratings:

@if (Model.ReviewTypeList.Count > 0)
{
    foreach (...)
    {
        ...
        <div class="review-rating">
            <div class="name-description">
                <label>@Html.Raw(additionalReview.Name):</label>
                <div class="tooltip">
                    <span class="tooltiptext">@Html.Raw(additionalReview.Description)</span>
                </div>
            </div>
            <div class="rating-wrapper">                                           
                <div class="label first">@T("Reviews.Fields.Rating.Bad")</div>
                <div class="rating-options">
                    ...
                </div>
                <div class="label last">@T("Reviews.Fields.Rating.Excellent")</div>
            </div>
        </div>
    }
}

This way the form will be much more flexible for styling.

Thanks a lot
/ Hristo

Hi Hristo,

Thanks a lot! I've just created two work items - one and two

Hi guys,
I just compared 4.0 and 4.1 as a memory usage and I noticed 4.1 uses 4.5 times more than 4.0. My 4.0 goes up to 192 MB max and on 4.1 it goes up to 866 MB.

a.m. wrote:
And here are fixes - one and two

dianoche wrote:

We conducted a series of tests using memory profilers, and concluded that the memory usage in nopCommerce 4.10 didn't change for the worse, at the beginning of the default installation, no more than 50 megabytes of memory are used, but for some reason, the memory alocator in Windows highlights for processes written on .Net Core RAM about 4 times more memory

for 4.0



for 4.1



Idk if it is not showing the real values. I tried to add images but I guess not showing.

Sergei-k wrote:

If the more memory usage is due to some EF database caching it is the best use of it.  I never understood what is the reason of comparing applications with the prejudice the less amount of RAM used is better.

I can rent dedicated servers with 64BG of RAM for 40-50 Euros/month nowadays and I would not be happy if an application would not use it.  An empty RAM is useless.

Of course it can be a bug, especially when the RAM usage keeps growing indefinitely, that's an other case, but if RAM is used for what it is made, it is the best thing.

I am fine with memory usage :) Just saw the difference and pointed it out. It is not a small difference so I thought it needs to be pointed out :)  

libor wrote:

Hello Andrei,

two more questions about the new rating functionality on product review pages.

First, it seems the rating criteria name for the additional ratings is still just an unwrapped text without any html tag as a placeholder:

@Html.Raw(additionalReview.Name)

Can you please wrap it in html, like this:

<label>@Html.Raw(additionalReview.Name):</label>


The other question is about the default state of the additional ratings. We were wondering why the admin setting for the main rating ("catalogsettings.defaultproductratingvalue") is not being applied to the additional ratings. So you can choose maximum value for the default rating, but the additional ratings are always set to minimum by default? What is the reason for that, it seems illogical. The logical option would be the admin setting to target all available ratings.
Any information on this will be appreciated.


Thanks a lot
/ Hristo

Hi Dianoche

"Hi guys,
I just compared 4.0 and 4.1 as a memory usage and I noticed 4.1 uses 4.5 times more than 4.0. My 4.0 goes up to 192 MB max and on 4.1 it goes up to 866 MB."

Do me a favour, please check your Application Pool Settings and make sure you have set "Enable 32bit Applications" = True, Hopefully that will resolve your issue.