nop-date-picker localization issue

This topic was automatically closed 365 days after the last reply. New replies are no longer allowed.
5 years ago
1. nopCommerce version
4.00

2. Expected behavior
A nopDatePicker should display day, month and year in the appropriate language.

3. Actual behavior
A nopDatePicker always displays day, month and year in English.

4. Steps to reproduce the problem
Add a date picker attribute to a product and select a language other than English. Check the date picker values in the product page.

5. Any private modifications you made to your nopCommerce
We've added in nop-date-picker:

- Presentation/Nop.Web/Areas/Admin/Views/Product/_ProductAttributes.cshtml
line 86, asp-localize-labels="true"

- Presentation/Nop.Web/Areas/Views/Product/_ProductAttributes.cshtml
line 148, asp-localize-labels="true"

By adding these lines in nop-date-picker, we are able to enter the if condition of Presentation/Nop.Web.Framework/TagHelpers/Shared/NopDatePickerTagHelper.cs line 184.

This fixes our issue for now but we believe that their must be something else to write than a raw string.

Best Regards
5 years ago
Same for Presentation/Nop.Web/Views/Customer/Register.cshtml line 94.
5 years ago
Thanks a lot, Florent! I've just fixed it. Please see this commit
This topic was automatically closed 365 days after the last reply. New replies are no longer allowed.