Find bugs in nopCommerce 4.10 BETA and earn $10

This topic was automatically closed 365 days after the last reply. New replies are no longer allowed.
5 years ago
In Libraries/Nop.Services/Common/PdfService.cs line 258:

//if you have really a lot of lines in the footer, then replace 9 with 10 or 11
var footerHeight = totalLines * 9;


This should be a parameter in the configuration area.


In Presentation/Nop.Web/Controllers/OrderController.cs line 195:

return File(bytes, MimeTypes.ApplicationPdf, $"order_{order.Id}.pdf");


"order_" should not be a raw string for localization purpose. This should be customizable by language.
5 years ago
Hi,

We believe there is a bug introduced in v4.10.
On clicking 'back to plugin list' from Miscellaneous plugin configure, it goes to exception. Because the action does not exist.

Steps to Reproduce:
1. Go to configuration of plugin of type IMiscPlugin.
2. Click on 'back to plugin list'.

Actual Result:
Ends to exception of action not found.

Reason:
Method Action name “Plugins” does not exist as specified in '..\Presentation\Nop.Web\Areas\Admin\Views\Shared\_ConfigurePlugin.cshtml'

Solution:
In '..\Presentation\Nop.Web\Areas\Admin\Views\Shared\_ConfigurePlugin.cshtml'

else if (plugin is IMiscPlugin)
{
    //Misc plugins
    activeMenuSystemName = "Plugins";
    configureLocale = "Admin.Configuration.Plugins.Misc.Configure";
    backToLocale = "Admin.Configuration.Plugins.Misc.BackToList";
    listActionMethodName = "Plugins";
    listControllerName = "Plugin";
}


Should have:
listActionMethodName = "List";


Hope this helps.

Best Regards,
Atluz Nop Team
5 years ago
Hi,

Found another bug. Plugin list lands in exception if no internet access.

Steps to Reproduce:
1. Switch off internet access.
2. Go to Plugin list in admin area.

Actual Result:
Unhandled exception and plugin list is not displayed

Reason:
Exception not handled in 'All plugin and themes'

Solution:
Add exception handling in '.\Libraries\Nop.Core\Plugins\OfficialFeedManager.cs'

Hope this helps.

Best Regards,
Atluz Nop Team
5 years ago
Hello community,

1) Product seo name isn't changed based on language selection

https://github.com/nopSolutions/nopCommerce/issues/3174

2)  Cannot add "empty" order note (validation required)

https://github.com/nopSolutions/nopCommerce/issues/3175


Hope, it would help to others once fix by nopcommerce team.
5 years ago
while finishing themes for the new version run into minor widgets zones missing:

web -> catalog -> serach.cshtml -> widgetZone = "productsearch_page_basic"
                            widgetZone = "productsearch_page_advanced"

admin -> VendorAttribute all createandupdate pages
5 years ago
fjeannot wrote:
In Libraries/Nop.Services/Messages/MessageTokenProvider.cs line 845[/code]

Thanks! Although it's not a bug (because it'll be redirected to HTTPs anyway) I've just created a work item

Please also note that "store.SecureUrl" property could be empty. So there should be other solution
5 years ago
fjeannot wrote:
In Presentation/Nop.Web.Framework/Security/Captcha/GReCaptchaValidator.cs line 53:
...
This code does not work when nopCommerce is behind a proxy.
[/code]

Thanks! We'll check it - https://github.com/nopSolutions/nopCommerce/issues/3181
5 years ago
atluz wrote:
On clicking 'back to plugin list' from Miscellaneous plugin configure, it goes to exception. Because the action does not exist.

Thanks! Fixed
5 years ago
sk5202 wrote:
1) Product seo name isn't changed based on language selection

https://github.com/nopSolutions/nopCommerce/issues/3174

2)  Cannot add "empty" order note (validation required)

https://github.com/nopSolutions/nopCommerce/issues/3175

Thanks a lot!
5 years ago
hezyz wrote:
web -> catalog -> serach.cshtml -> widgetZone = "productsearch_page_basic"
                            widgetZone = "productsearch_page_advanced"

Both of them exist at \Nop.Web\Views\Catalog\Search.cshtml

hezyz wrote:
admin -> VendorAttribute all createandupdate pages

What exactly widget zones are missing? For example, check \Nop.Web\Areas\Admin\Views\Vendor\Edit.cshtml
This topic was automatically closed 365 days after the last reply. New replies are no longer allowed.