nopCommerce 3.90 BETA released. Please share your impressions

hope this method  bool IsMinimumOrderPlacementIntervalValid(Customer customer) in checkoutcontroller moved to factory pattern. and waiting for nop.factory :)

Thank you nopCommerce Team.
Start Test and Resource file check.

Good work Andrei and the nop team. One small thing I noticed is that the new Shipping.FixedOrByWeight plugin is targeting .NET framework 4.5.2 whereas the rest of the projects in the solution are targeting 4.5.1

The requirements groups feature is very impressive.
Explanation is needed for how a group could be used many times as a template

BUG: After several tests nesting requirement groups it started to fail when I wanted to add further requirements (at any level); even that I was setting the requirement content it reported that it failed to load it:

Requirement Must be assigned to customer role  
Failed to load requirement content.

This happened with "Must be assigned to customer role" and "Customer had spent X" (I didn't try others). It worked fine for a while but apparently the prblems started when I created  a group with the same name as a previous group.

Tecnofin wrote:

Tried again without duplicating group names and the problem appeared again. May it is when several (about 5+) requirements are in place and the site is slow. When adding a new one, all requirements contents are reloaded and some of them fail; not always the same fail, one time one reloads and maybe the next time it fails. The demo site I was using was a bit slow

Here is an example of the settings in my test:


Group Default requirement group Interaction type in this group is
Requirement Customer had spent x.xx amount  Remove requirement
Required spent amount  

6.0000


Save
AND
Requirement Customer had spent x.xx amount  Remove requirement
Failed to load requirement content.
AND
Requirement Must be assigned to customer role  Remove requirement
Failed to load requirement content.
AND
Requirement Must be assigned to customer role  Remove requirement
Failed to load requirement content.
AND
Group test1 Interaction type in this group is Remove group
Requirement Must be assigned to customer role  Remove requirement
Required customer role  Save
AND
Requirement Must be assigned to customer role  Remove requirement
Failed to load requirement content.
AND
Requirement Must be assigned to customer role  Remove requirement
Failed to load requirement content.
AND
Requirement Must be assigned to customer role  Remove requirement
Required customer role  Save
AND
Requirement Must be assigned to customer role  Remove requirement
Failed to load requirement content.
AND
Requirement Must be assigned to customer role  Remove requirement
Failed to load requirement content.
AND
Requirement Must be assigned to customer role  Remove requirement
Required customer role  Save
AND
Requirement Must be assigned to customer role  Remove requirement
Required customer role  Save
AND
Requirement Must be assigned to customer role  Remove requirement
Required customer role  Save
AND
Requirement Customer had spent x.xx amount  Remove requirement
Required spent amount  

3.0000


Save
AND
Requirement Customer had spent x.xx amount  Remove requirement
Required spent amount  

3.0000


Save
AND
Requirement Customer had spent x.xx amount  Remove requirement
Failed to load requirement content.
AND
Group test2 Interaction type in this group is Remove group
Requirement Customer had spent x.xx amount  Remove requirement
Required spent amount  

17.0000


Save
AND
Requirement Customer had spent x.xx amount  Remove requirement
Failed to load requirement content.

Great work and worked on long list of improvements and bug fixes,

TinyMCE editor in email template is replaced with textarea, is it only because of conditional statements in the email template?

Tecnofin wrote:

Hi.
Thanks for your review.
I just tested the described issue with discount requirements. And it works like a charm.
I tested this at local machine and at our internal server with many requirements and with deeply nesting and also with duplicated group names, there are no errors.
Most likely error was associated with a slow server on which you tested new version.

falkao wrote:

First off, I would like to say the 3.9 beta looks like a pretty nice upgrade. However, I do agree with a few points falkao makes, and would hopefully see them in 3.9. I think there are too many calls to the shopping cart as well. Addressing that could improve performance for sure. Also I agree that rounding config needs to be improved and did a pull request here: https://github.com/nopSolutions/nopCommerce/pull/1983 Maybe some developers from the EU could add more EU specific things there. Also the forum thread for that topic can be found here: https://www.nopcommerce.com/boards/t/41958/suggestion-ordertotal-rounding.aspx#176813

falkao wrote:

and

[email protected] wrote:

Thanks! Please see https://github.com/nopSolutions/nopCommerce/commits/issue-1424-OrderTotal_Rounding this branch. I would really appreciate if you could download and test it out. Most probably, we'll merge it in 3.90