As I'm relatively new to making contributions to nopcommerce and I'm not sure of the etiquette around this my questions are:
1. Should this be raised as a new issue or fixed as part of the original. Is it okay to bundle this small (kind of related) fix in with the original pull request or should it be a completely new one?
2. Is it okay to raise issues myself on github? I noticed a lot of the time that issues on this forum get converted to issues on github by moderators. So is it okay for me to go direct to the nopcommerce github and raise them myself or should I continue to raise them here first?
After looking into this some more I have decided to go ahead and create this as a new issue directly on github.
not sure if this is a bug and if it was planned that nopCommerce 4.2 would be running on Mac OS X. As I read the issue https://github.com/nopSolutions/nopCommerce/issues/3095 I saw that also running on Mac was pointed here.
I checked this today and had problems with install step. What I found that problems were in FilePermissionHelper.cs. Arguments for shell script should be different for Mac OS X (I use macOS Mojave Version 10.14.4) as stat command accepts little bit different params. Probably this could be added to repo with some additional check if Unix is actually Mac OS X.
not sure if this is a bug and if it was planned that nopCommerce 4.2 would be running on Mac OS X. As I read the issue https://github.com/nopSolutions/nopCommerce/issues/3095 I saw that also running on Mac was pointed here.
I checked this today and had problems with install step. What I found that problems were in FilePermissionHelper.cs. Arguments for shell script should be different for Mac OS X (I use macOS Mojave Version 10.14.4) as stat command accepts little bit different params. Probably this could be added to repo with some additional check if Unix is actually Mac OS X.
Another bug that is in Nop commerce for very long time. The problem with return request.
Nop commerce allows posting return request for an item multiple times. Example if 1 quantity is ordered and customer posts the return request for 1 quantity. He can post the same item and quantity multiple times.
This also happens if you change the return request status to success from admin too.
This bug is related to the Affiliate program feature of nop commerce.
If someone opens the a nop commerce site using affiliate link without login. And adds an item in cart. And before checkout the customer logs in to process the checkout, then actual customer id and placed order is mapped to the affiliate.
Does nopCommerce 4.2 or Net.Core support UNC path with IIS? I currently use nop3.9 with multiple servers accessing a UNC path.
I get the following error along with a new folder that matches the UNC path created in the root folder.
info: Microsoft.AspNetCore.DataProtection.KeyManagement.XmlKeyManager[58] Creating key {5cc54dda-ea05-45e9-88f2-0f8faecae7f7} with creation date 2019-05-09 21:50:44Z, activation date 2019-05-09 21:50:44Z, and expiration date 2019-08-07 21:50:44Z. warn: Microsoft.AspNetCore.DataProtection.KeyManagement.XmlKeyManager[35] No XML encryptor configured. Key {5cc54dda-ea05-45e9-88f2-0f8faecae7f7} may be persisted to storage in unencrypted form. info: Microsoft.AspNetCore.DataProtection.Repositories.FileSystemXmlRepository[39] Writing data to file '\\192.168.1.210\webshare1\TestSite\192.168.1.210\webshare1\TestSite\App_Data\DataProtectionKeys\key-5cc54dda-ea05-45e9-88f2-0f8faecae7f7.xml'. Application startup exception: System.ArgumentException: The path must be absolute. Parameter name: root at Microsoft.Extensions.FileProviders.PhysicalFileProvider..ctor(String root, ExclusionFilters filters) at Nop.Web.Framework.Infrastructure.Extensions.ApplicationBuilderExtensions.UseNopStaticFiles(IApplicationBuilder application) in C:\Users\JKRAUSS\Documents\DSGI\nopCommerce_4.20_Beta_Source\Presentation\Nop.Web.Framework\Infrastructure\Extensions\ApplicationBuilderExtensions.cs:line 197 at Nop.Web.Framework.Infrastructure.NopCommonStartup.Configure(IApplicationBuilder application) in C:\Users\JKRAUSS\Documents\DSGI\nopCommerce_4.20_Beta_Source\Presentation\Nop.Web.Framework\Infrastructure\NopCommonStartup.cs:line 63 at Nop.Core.Infrastructure.NopEngine.ConfigureRequestPipeline(IApplicationBuilder application) in C:\Users\JKRAUSS\Documents\DSGI\nopCommerce_4.20_Beta_Source\Libraries\Nop.Core\Infrastructure\NopEngine.cs:line 201 --- End of stack trace from previous location where exception was thrown --- at Microsoft.AspNetCore.Hosting.ConventionBasedStartup.Configure(IApplicationBuilder app) at Microsoft.AspNetCore.Hosting.Internal.WebHost.BuildApplication() crit: Microsoft.AspNetCore.Hosting.Internal.WebHost[6] Application startup exception System.ArgumentException: The path must be absolute. Parameter name: root at Microsoft.Extensions.FileProviders.PhysicalFileProvider..ctor(String root, ExclusionFilters filters) at Nop.Web.Framework.Infrastructure.Extensions.ApplicationBuilderExtensions.UseNopStaticFiles(IApplicationBuilder application) in C:\Users\JKRAUSS\Documents\DSGI\nopCommerce_4.20_Beta_Source\Presentation\Nop.Web.Framework\Infrastructure\Extensions\ApplicationBuilderExtensions.cs:line 197 at Nop.Web.Framework.Infrastructure.NopCommonStartup.Configure(IApplicationBuilder application) in C:\Users\JKRAUSS\Documents\DSGI\nopCommerce_4.20_Beta_Source\Presentation\Nop.Web.Framework\Infrastructure\NopCommonStartup.cs:line 63 at Nop.Core.Infrastructure.NopEngine.ConfigureRequestPipeline(IApplicationBuilder application) in C:\Users\JKRAUSS\Documents\DSGI\nopCommerce_4.20_Beta_Source\Libraries\Nop.Core\Infrastructure\NopEngine.cs:line 201 --- End of stack trace from previous location where exception was thrown --- at Microsoft.AspNetCore.Hosting.ConventionBasedStartup.Configure(IApplicationBuilder app) at Microsoft.AspNetCore.Hosting.Internal.WebHost.BuildApplication() Hosting environment: Production Content root path: \\192.168.1.210\webshare1\TestSite Now listening on: http://127.0.0.1:4386 Application started. Press Ctrl+C to shut down. info: Microsoft.AspNetCore.Hosting.Internal.WebHost[1] Request starting HTTP/1.1 GET http://testarms.com/ info: Microsoft.AspNetCore.Hosting.Internal.WebHost[2] Request finished in 141.9697ms 500 text/html; charset=utf-8 info: Microsoft.AspNetCore.Hosting.Internal.WebHost[1] Request starting HTTP/1.1 GET http://testarms.com/favicon.ico info: Microsoft.AspNetCore.Hosting.Internal.WebHost[2] Request finished in 0.4327ms 500 text/html; charset=utf-8 info: Microsoft.AspNetCore.Hosting.Internal.WebHost[1] Request starting HTTP/1.1 POST http://127.0.0.1:4386/iisintegration 0 info: Microsoft.AspNetCore.Hosting.Internal.WebHost[2] Request finished in 0.2107ms 500 text/html; charset=utf-8 Application is shutting down...
