Very Nice! I'll have a look at it later today.
What happened to OrderService.GetOrderByAuthorizationTransactionIdAndPaymentMethodAsync(..,..); ?
Should I implement this function in our own plugin or will this function return in the final version of 4.4?
My main expectations from this version are :
1. webp images support
2. 301 url redirect
3. Set fixed commission and category-based commission for vendors (as a percentage for each seller separately)
and set payment days for vendors.
Regarding the above, on 2nd thoughts, it may be better to just have one environment variable to override the App_Data path as there are a lot of places where this is used.
Do you have any ETA on 4.40? I might start a new site using 4.40 beta and wait for full version before we go to production.
Please consider refactoring for Tax Provider plugins. Having introduced the additional method GetTaxTotal() in 4.30 complicated things for tax provider developers. Now, all devs need to be able to handle the same in regards to getting (possible) tax for
- order line items
- checkout attributes
- payment fee
And also having to determine which address to use
//tax is based on billing address
//tax is based on shipping address
//tax is based on pickup point address
//or use default address for tax calculation
And also dealing with tax exemptions
I.e. Similar code needs to be replicated by each developer.
(Look at Avalara - ~ 600 lines of code for such caclulations. I don't even see Tax.FixedOrByCountryStateZip dealing with 'exemption'; maybe it's handled elsewhere in core. Which is maybe also redundant because similar tax related calculations are also in OrderTotalCalculationService ...
var (_, _, _, _, orderSubTotalTaxRates) = await _orderTotalCalculationService
I think there should be (at least) methods added to the Tax Service that can provide a (e.g.) List<TaxableItems> GetTaxableItems(), and