Profile: implexisIT

We have a background task that depends on _pictureService.GetPictureUrl method. In the method GetImagesPathUrl (which is called by GetThumbUrl) the _httpContextAccessor.HttpContext is NULL and throws an error. In 4.10 this method didn't exist and the shop path was handled by webHelper.GetStoreLocation(); I guess the Task doesn't have a  context, hence the exception.

currently the method doesn't work properly when allCategories List is provided.

Line number 760 looks like this:
  

category = allCategories != null ? allCategories.FirstOrDefault(c => c.Id == c.ParentCategoryId)

  

it must be like this:

category = allCategories != null ? allCategories.FirstOrDefault(c => c.Id == category.ParentCategoryId)

here is the current full code:

public virtual IList<Category> GetCategoryBreadCrumb(Category category, IList<Category> allCategories = null, bool showHidden = false)
        {
            if (category == null)
                throw new ArgumentNullException(nameof(category));

            var result = new List<Category>();

            //used to prevent circular references
            var alreadyProcessedCategoryIds = new List<int>();

            while (category != null && //not null
                !category.Deleted && //not deleted
                (showHidden || category.Published) && //published
                (showHidden || _aclService.Authorize(category)) && //ACL
                (showHidden || _storeMappingService.Authorize(category)) && //Store mapping
                !alreadyProcessedCategoryIds.Contains(category.Id)) //prevent circular references
            {
                result.Add(category);

                alreadyProcessedCategoryIds.Add(category.Id);

                category = allCategories != null ? allCategories.FirstOrDefault(c => c.Id == category.ParentCategoryId)
                    : this.GetCategoryById(category.ParentCategoryId);
            }
            result.Reverse();
            return result;
        }

same here, doesnt work for me, doesnt work for my colleagues. You have to restart the application to see the plugin changes. The list in PluginManager.ReferencedPlugins isn't updated after a plugin is installed or uninstalled. I haven't investigated further, but we are not the only ones who have this issue.

Nop-Templates.com wrote:

Been looking for hours for this... Documentation update would be very much appreciated. Hope nopCommerce team sees this. The upgrade guide only tells you to look at the new implemntation, but not on how to actually use it in a plugin... Thanks for your input.