Find bugs in nopCommerce 4.30 BETA and earn $10

This topic was automatically closed 365 days after the last reply. New replies are no longer allowed.
4 года назад
FlameX wrote:
Unable to upload pictures in the backoffice, the upload a file button is missing in all pages(Product/Category/Manufacturer etc.), we have tried in both Firefox and Chrome


I have the same issue, no picture upload in all the admin area.  Could you find the cause?
4 года назад
libor wrote:
Unable to upload pictures in the backoffice, the upload a file button is missing in all pages(Product/Category/Manufacturer etc.), we have tried in both Firefox and Chrome

I have the same issue, no picture upload in all the admin area.  Could you find the cause?

This is already fixed. Please check with latest source code.
4 года назад
Typo in  \Plugins\Nop.Plugin.Shipping.UPS\Services\UPSService.cs
'error' should be 'saturdayError':

//get rates for saturday delivery
if (_upsSettings.SaturdayDeliveryEnabled)
{
    var (saturdayShippingOptions, saturdayError) = GetShippingOptions(shippingOptionRequest, true);
    foreach (var shippingOption in saturdayShippingOptions)
    {
        response.ShippingOptions.Add(shippingOption);
    }
    if (!string.IsNullOrEmpty(error))
        response.Errors.Add(error);
}



(and 'saturday' in the comments should be init capped = Saturday ;)
4 года назад
New York wrote:
Typo in  \Plugins\Nop.Plugin.Shipping.UPS\Services\UPSService.cs

Thanks a lot for reporting. We'll fix it soon - https://github.com/nopSolutions/nopCommerce/issues/4592
3 года назад
New York wrote:
Typo in  \Plugins\Nop.Plugin.Shipping.UPS\Services\UPSService.cs
'error' should be 'saturdayError':

//get rates for saturday delivery
if (_upsSettings.SaturdayDeliveryEnabled)
{
    var (saturdayShippingOptions, saturdayError) = GetShippingOptions(shippingOptionRequest, true);
    foreach (var shippingOption in saturdayShippingOptions)
    {
        response.ShippingOptions.Add(shippingOption);
    }
    if (!string.IsNullOrEmpty(error))
        response.Errors.Add(error);
}



(and 'saturday' in the comments should be init capped = Saturday ;)

Done. You can see changes here.
3 года назад
Stored Procedure - ProductLoadAllPaged is missing default sorting.
If sorting products by Position on any category page the result is returned order by product.Id and not order by product.DisplayOrder... did not look into MySql...

ELSE IF @OrderBy = 0 /* default sorting, 0 (position) */
    SET @sql_orderby = ' p.[DisplayOrder] ASC'
3 года назад
Nop.Services.Catalog.CategoryService - GetProductCategoriesByCategoryId
Should it not be
var query = from pc in _productCategoryRepository.Table
                        join p in _productRepository.Table on pc.ProductId equals p.Id
                        where pc.CategoryId == categoryId &&
                              !p.Deleted &&
                              (showHidden || p.Published)
                        orderby p.DisplayOrder
                        select pc;


instead of

var query = from pc in _productCategoryRepository.Table
                        join p in _productRepository.Table on pc.ProductId equals p.Id
                        where pc.CategoryId == categoryId &&
                              !p.Deleted &&
                              (showHidden || p.Published)
                        orderby pc.Id, pc.DisplayOrder
                        select pc;


in order to display products on /Admin/Category/Edit/ as intended?
3 года назад
mcselasvegas wrote:
Nop.Services.Catalog.CategoryService - GetProductCategoriesByCategoryId
...
instead of
...
                        orderby pc.Id, pc.DisplayOrder
                        select pc;



Where are you seeing
  orderby pc.Id, pc.DisplayOrder

I see
  orderby pc.DisplayOrder, pc.Id

on line 556 in repo
3 года назад
I was probably playing around with the source and ended up posting my code instead the repository... but it does not matter... it needs to order the product not the category....
3 года назад
never mind my posts above... I was looking at the Product.DisplayOrder and not the Product_Category_Mapping.DisplayOrder
This topic was automatically closed 365 days after the last reply. New replies are no longer allowed.