Discount on Cart Subtotal plugin (By nopCommercePlus)

i had issue that plugin didn't take in calculation checkout specific attribute , I talk to support of forefront and they fix it for me right away and send me updated build

WARNING to nopCommerce 4.1 users (and possibly other versions). This plugin will CRASH YOUR SITE with StackOverflowException when used with coupon types of "apply to products", "apply to categories", or "apply to manufacturers".

Developers need to properly test this product.

4.40 When will this version be released? Please publish we cannot use it.

I have the same exception as other user below. After installed plugin - GetSubTotal started running in the loop and finished with the exception - Overflow exception.
Other plugin works with the same error. Both plugins for discount "over x.XX amount" and "min x.XX amount has this exception loop". I could give you more information.
Conditions to reproduce:
1) set "Discount type" = "Assigned to products"
2) add "Requirement Customer spending over x.xx amount"
3) set "Required spending amount" something like = 50 (or others)
4) add product to discount rule "Product1"
5) go to "Product1" and click "Buy" - "Product1" will be add to shopping cart
6) logout - login - it started Infinite loop for Nop 4.3 "ShoppingCartService" line 1176 - "GetSubTotal" for this product.

For disable this - set "Discount type" = "Assigned to subtotal".

Good plugin, working perfect, and quick and appropiate support.

Our store is running a tiered discount sale based on cart subtotal. I was having an issue getting it to install and work properly. The support team worked with me until it was working perfectly. Happy with the plugin and support team.

The 4.30 version is obviously untested and broken.  If I install it anywhere on my live site, the site will never come up again until the plugin is manually removed from the .json.  It throws this error every time:

Faulting application name: w3wp.exe, version: 10.0.17763.1, time stamp: 0xcfdb13d8
Faulting module name: coreclr.dll, version: 4.700.20.20201, time stamp: 0x5e867108
Exception code: 0xc0000005
Fault offset: 0x000000000027773e
Faulting process id: 0x1084
Faulting application start time: 0x01d642eaeade422a
Faulting application path: c:\windows\system32\inetsrv\w3wp.exe
Faulting module path: C:\Program Files\dotnet\shared\Microsoft.NETCore.App\3.1.4\coreclr.dll
Report Id: 76bd0941-4daa-4490-8637-bf52e3f215a5
Faulting package full name:
Faulting package-relative application ID:

It also leaves an IIS worker process running at 30% of the cpu perpetually, on a test site with only one user... and w3wp.exe errors like the above appear to be very common for programs with infinite recursion... so it's safe to say this code is garbage.  Judging by the comments it hasn't worked since 3.90, so they probably never actually rewrote their code for the new .net core.

Save yourself the trouble and either write your own or find a better way to do your discounts.

Can you share these plugin codes?

Using in NopCommerce 3.90 & running fine, and having issue during initial deployment on live server, however issue resolved with great support from the developer team.

In the description, this plugin supports nopcommerce V4.10 & v4.20 but Unfortunately
after download, plugin not supports noppcomerce 4.10 and 4.20.
Please correct this and if possible update this plugin for V4.10 & 4.20.
Thanks.

Hi,
i developed the same plugin, but an stackover flow exception occur when i try to get ShoppingCartItems subtotal in CheckRequirement method.

var subTotal = this._priceCalculationService.GetSubTotal(item, true);

i noticed that your plugin have the same problem.
you can fix it by setting 'includeDiscounts' property into 'false' in 'GetSubTotal' method.
but it cause some miss calculation.

In the description, it is mentioned that this plugin supports nopcommerce V4.10 but Unfortunately
In the developer’s website, it says the plugin only supports noppcomerce up to V4.00.
Please correct this and if possible update this plugin for V4.10. It is very useful.
Thanks.

It is a good plugin and working as expected.

Very bad C# code. You created many flags variable to check some condition.

For example. HasValue property return true, but in your code you assigned to flag variables.

This is a good plugin to calculate the discount on shopping cart.