nopCommerce 4.40 - Bug fixes and improvements

This topic was automatically closed 365 days after the last reply. New replies are no longer allowed.
3 年 前
Thanks, Maksim!

One more thing.
You have added settings for enabling/disabling the price range and manufacturer filters but there is no setting for disabling the specification filters. I think you have simply forgotten about.
We will need such a setting as we have our own Ajax Filters plugin and we don't really need to execute the code that builds the default specification filters as it will slow down the loading of the category pages (as we already execute our own logic for building the specification filters).
Also based on our experience, these queries for building the specifications could be quite heavy (we have seen stores with 1M+ specification options) and some store owners might prefer to disable the specification filters in return of better page speed so such an option will be useful anyway.

Thanks,
Boyko
3 年 前
Nop-Templates.com wrote:
You have added settings for enabling/disabling the price range and manufacturer filters but there is no setting for disabling the specification filters...

Thanks, here is a work item

P.S. No, we haven't forgotten about it because a store owner can always disabled specification attributes with the "Allow filtering" option
3 年 前
Nop team
You remove the method
void UninstallPermissions(IPermissionProvider permissionProvider);
from the class IPermissionService
Please add it back with Async mode
3 年 前
a.m. wrote:
Thanks, here is a work item


Thank you Andrei!

Yes, having a single setting is much easier than going through all the specifications and removing the "Allow filtering" options one by one which is a lot of work.

By the way, you should consider having a simple setting for Enable/Disable the Featured Products on the Home page.
Currently, if you want to remove them from the Home page you need to go through all the products and uncheck the setting per product, and since there is no search option to find all these products easily then the process of turning all of them off is very time-consuming.
A simple setting would be quite handy for store owners.

Thanks,
Boyko
3 年 前
a.m. wrote:
You have added settings for enabling/disabling the price range and manufacturer filters but there is no setting for disabling the specification filters...
Thanks, here is a work item

P.S. No, we haven't forgotten about it because a store owner can always disabled specification attributes with the "Allow filtering" option

You do not forgotten but you create a work item :D :D
2 年 前
Hello nopCommerce.

It seems we missed to notify you about a bug with the markup of the new "Specification Group" names inside the product specification table that we found upon the version 4.40 release.

The html markup for specification group names is currently invalid.
Group names are currently rendered as a single table cell, while the number of the table cells for each specification is 2 - name and value.
The W3C standard is not allowing different number of table cells per row within the same table, this is invalid markup. If one needs different number of cells, they need to use the colspan attribute on the cell that doesn't match the rest of the table. In this case colspan="2" is needed, as long as the rest of the table is always having 2 cells per row. That should be a very simple fix. No css changes are required.

By the way, it's a good idea to add a class name on the <tr> element that contains the group name, so we can differentiate it from other table rows within the same table.

Please let me know if you need any additional info.

Thanks in advance
/ Hristo
2 年 前
Nop-Templates.com wrote:
It seems we missed to notify you about a bug with the markup of the new "Specification Group" names...

Hi Hristo! Thanks a lot! Here is a work item
2 年 前
Hello,
There is a problem with bundle CSS files. Using this property 'box-shadow: 0 4px 10px 0 rgb(33 33 33 / 15%);' anywhere in CSS file the bundle.css gets created but the bundle.min.css file doesn't get created and the browser console error is 'Refused to apply style from 'https://localhost:44369/bundles/bundle.min.css' because its MIME type ('') is not a supported stylesheet MIME type, and strict MIME checking is enabled'.
Nop version 4.40 clean install.
2 年 前
Nop-Templates.com wrote:
Hi guys,

In nopCommerce 4.40 the text of multiple specification values is comma-separated, but we noticed that the commas are added even if the values are "attribute squares" and not text. Here is a screenshot of how the product page is currently looking in DefaultClean theme - the layout is a bit messy.
We found the same issue on product details pages and on compare products pages.

Can you please change the commas to be added only for text values, but not for color squares?

Thanks,
Boyko

We've closed this issue. Details here
2 年 前
Nop-Templates.com wrote:
Hello nopCommerce.

It seems we missed to notify you about a bug with the markup of the new "Specification Group" names inside the product specification table that we found upon the version 4.40 release.

The html markup for specification group names is currently invalid.
Group names are currently rendered as a single table cell, while the number of the table cells for each specification is 2 - name and value.
The W3C standard is not allowing different number of table cells per row within the same table, this is invalid markup. If one needs different number of cells, they need to use the colspan attribute on the cell that doesn't match the rest of the table. In this case colspan="2" is needed, as long as the rest of the table is always having 2 cells per row. That should be a very simple fix. No css changes are required.

By the way, it's a good idea to add a class name on the <tr> element that contains the group name, so we can differentiate it from other table rows within the same table.

Please let me know if you need any additional info.

Thanks in advance
/ Hristo

Hi! We've just completed it. Please find the commit here
This topic was automatically closed 365 days after the last reply. New replies are no longer allowed.