MessageTokenProvider does not use the languageId parameter

In nopCommerce 2.1 in the MessageTokenProvider class, there is a method:

protected virtual string ProductListToHtmlTable(Order order, int languageId)

But a bit lower  there is one line of code:

if (!String.IsNullOrEmpty(opv.ProductVariant.GetLocalized(x => x.Name)))

This in turn will try to get the languageId from the work context. In my case, this is a task and the context is a "fake context", which will cause a lot of notimplementedexceptions...

You're absolutely right. Fixed. Thanks!

Great, thanks!

Found a few of the same bug a bit lower down in the same method as well

The same goes for line 289, 299 and 305 as well but with this line instead:

_priceFormatter.FormatPrice(orderTaxInCustomerCurrency, true, order.CustomerCurrencyCode, false);

Which should be:

_priceFormatter.FormatPrice(orderTaxInCustomerCurrency, true, order.CustomerCurrencyCode, language, false);

Thanks! In the first method you pass 'false' for 'showTax' parameter. But in the second one you pass it for 'priceIncludeTax' param.

a.m. wrote:

Oh, youre right. How should I write it then? Should it be true or false?

You should pass both 'priceIncludeTax' and 'showTax' parameters. Look at PriceFormatter implementation in order to know how to get the current 'priceIncludeTax' parameter