a.m. wrote:I guess many other nopCommerce developers are using them a lot so it would be nice to have them back or have some alternative way to add custom data to the models
Originally we marked them as [Obsolete] to see any reaction from our community whether it's really required or used (the
commit with some details). Considering that no one argued about it, we've decided to remove this property later (the
commit).
I would suggest using "TempData" now to pass any custom data to views from controllers
Hi Andrei,
Thank you for your reply!
I see now but to be honest I haven't noticed that it was marked as "Obsolate" and I didn't know that you plan to remove it completely that is why I was really shocked initially. I don't know how many developers are looking at every commit in the Develop branch and notice such changes (I personally don't check them until the Beta as it is still work in progress and things change all the time).
If it was marked as Obsolete in 4.5 I would have probably noticed it and knowing you are about to remove it and take some actions about it.
Is it possible to get it back for 4.6? You can leave the Obsolate attribute and add a comment explaining that it will be removed in nopCommerce 4.7 and suggest to use TempData instead. This way the developers will stop using them and will be prapared for the complete removal and also provide feedback with pros and cons and you can decide based on this if they need to be removed or not.
In general I think it is a really nice extensibility point that really helps developers to easily extend nopCommerce from plugins so as a developer I am not happy this needs to be removed and especially when I have a ton of code already using it.
We really use it heavily in the Administration of our plugins where we have backend code that relies on CustomProperties i.e Product, Category and Manufacturer mappings. So we need the binding to custom properties to also work as before.
This change affects all our plugins that support Mappings in the administation i.e JCarousel etc. and also plugins in the public area like One Page Checkout, Instant Search, Quick View, Rich Blog and some custom functionality in the themes.
Anyway I really wish we had this discussion several months ago and not in the last minute prior to the release. I really don't know if we will be able to rewrite everything (and as I said we really use it a lot in our plugins) considering there is less than a week to the official realease.
I hope other developers can share their views on this as well as most probably we are not the only ones using this (I know several clients with custom projects that are also using it).
Thanks,
Boyko