Hello, I have made two workitems to describe the bugs but they have not been assigned
http://nopcommerce.codeplex.com/workitem/10419
http://nopcommerce.codeplex.com/workitem/10471
But the impact is very big! I explain : Some calculations are divided in two method calls, one for incl tax and one for exc tax. Examples:
decimal? shippingExclTax = GetShoppingCartShippingTotal(cart, false, out taxRate);
decimal? shippingInclTax = GetShoppingCartShippingTotal(cart, true, out taxRate);
or
orderShippingTotalInclTax = _orderTotalCalculationService.GetShoppingCartShippingTotal(cart, true, out taxRate, out shippingTotalDiscount);
orderShippingTotalExclTax = _orderTotalCalculationService.GetShoppingCartShippingTotal(cart, false);
Each call is using freeShippingOverX value in there formulas, but sometimes cart total tax incl is bigger than X and cart total excl tax is lower than X on the same order! So the results are inconsistent...
My opinion is that these calculations are cpu consuming and should not be called twice. Each call could return both incl and excl tax.
Can you help me?