asoares wrote:The only place a NopObjectContext is registered in the dependency injection container is in Nop.Web.Framework.DependencyRegistrar.Register method and its registered as an IDbContext (which is used in EfRepository<> ctor). I checked the CategoryService in my version and its ctor does not take a NopObjectContext, its signature is:
public CategoryService(ICacheManager cacheManager,
IRepository<Category> categoryRepository,
IRepository<ProductCategory> productCategoryRepository,
IRepository<Product> productRepository)
Where did you see the code you posted? Does that come from a plugin that defines a new ICategoryService?
No this is from version 1.9 here is the whole class
[code]
using System;
using System.Collections.Generic;
using System.Linq;
using NopSolutions.NopCommerce.BusinessLogic.Caching;
using NopSolutions.NopCommerce.BusinessLogic.Configuration.Settings;
using NopSolutions.NopCommerce.BusinessLogic.Data;
using NopSolutions.NopCommerce.BusinessLogic.Infrastructure;
using NopSolutions.NopCommerce.Common.Utils;
namespace NopSolutions.NopCommerce.BusinessLogic.Categories
{
/// <summary>
/// Category service
/// </summary>
public partial class CategoryService : ICategoryService
{
#region Constants
private const string CATEGORIES_BY_ID_KEY = "Nop.category.id-{0}";
private const string PRODUCTCATEGORIES_ALLBYCATEGORYID_KEY = "Nop.productcategory.allbycategoryid-{0}-{1}";
private const string PRODUCTCATEGORIES_ALLBYPRODUCTID_KEY = "Nop.productcategory.allbyproductid-{0}-{1}";
private const string PRODUCTCATEGORIES_BY_ID_KEY = "Nop.productcategory.id-{0}";
private const string CATEGORIES_PATTERN_KEY = "Nop.category.";
private const string PRODUCTCATEGORIES_PATTERN_KEY = "Nop.productcategory.";
#endregion
#region Fields
/// <summary>
/// Object context
/// </summary>
private readonly NopObjectContext _context;
/// <summary>
/// Cache manager
/// </summary>
private readonly ICacheManager _cacheManager;
#endregion
#region Ctor
/// <summary>
/// Ctor
/// </summary>
/// <param name="context">Object context</param>
public CategoryService(NopObjectContext context)
{
this._context = context;
this._cacheManager = new NopRequestCache();
}
#endregion
#region Methods
/// <summary>
/// Is access denied
/// </summary>
/// <param name="category">Category</param>
/// <returns>true - access is denied; otherwise, false</returns>
public bool IsCategoryAccessDenied(Category category)
{
if (category == null)
throw new ArgumentNullException("category");
return category.IsAccessDenied(_context);
}
/// <summary>
/// Marks category as deleted
/// </summary>
/// <param name="categoryId">Category identifier</param>
public void MarkCategoryAsDeleted(int categoryId)
{
var category = GetCategoryById(categoryId);
if (category != null)
{
category.Deleted = true;
UpdateCategory(category);
}
}
/// <summary>
/// Gets all categories
/// </summary>
/// <returns>Categories</returns>
public List<Category> GetAllCategories()
{
bool showHidden = NopContext.Current.IsAdmin;
return GetAllCategories(showHidden);
}
/// <summary>
/// Gets all categories
/// </summary>
/// <param name="showHidden">A value indicating whether to show hidden records</param>
/// <returns>Categories</returns>
public List<Category> GetAllCategories(bool showHidden)
{
var query = from c in _context.Categories
orderby c.ParentCategoryId, c.DisplayOrder
where (showHidden || c.Published) &&
!c.Deleted
select c;
//filter by access control list (public store)
if (!showHidden)
{
query = query.WhereAclPerObjectNotDenied(_context);
}
var unsortedCategories = query.ToList();
//sort categories
//TODO sort categories on database layer
var sortedCategories = unsortedCategories.SortCategoriesForTree(0);
return sortedCategories;
}
/// <summary>
/// Gets all categories by parent category identifier
/// </summary>
/// <param name="parentCategoryId">Parent category identifier</param>
/// <returns>Category collection</returns>
public List<Category> GetAllCategoriesByParentCategoryId(int parentCategoryId)
{
bool showHidden = NopContext.Current.IsAdmin;
return GetAllCategoriesByParentCategoryId(parentCategoryId, showHidden);
}
/// <summary>
/// Gets all categories filtered by parent category identifier
/// </summary>
/// <param name="parentCategoryId">Parent category identifier</param>
/// <param name="showHidden">A value indicating whether to show hidden records</param>
/// <returns>Category collection</returns>
public List<Category> GetAllCategoriesByParentCategoryId(int parentCategoryId,
bool showHidden)
{
var query = from c in _context.Categories
orderby c.DisplayOrder
where (showHidden || c.Published) &&
!c.Deleted &&
c.ParentCategoryId == parentCategoryId
select c;
//filter by access control list (public store)
if (!showHidden)
{
query = query.WhereAclPerObjectNotDenied(_context);
}
var categories = query.ToList();
return categories;
}
/// <summary>
/// Gets all categories displayed on the home page
/// </summary>
/// <returns>Category collection</returns>
public List<Category> GetAllCategoriesDisplayedOnHomePage()
{
bool showHidden = NopContext.Current.IsAdmin;
var query = from c in _context.Categories
orderby c.DisplayOrder
where (showHidden || c.Published) && !c.Deleted && c.ShowOnHomePage
select c;
//filter by access control list (public store)
if (!showHidden)
{
query = query.WhereAclPerObjectNotDenied(_context);
}
var categories = query.ToList();
return categories;
}
/// <summary>
/// Gets a category
/// </summary>
/// <param name="categoryId">Category identifier</param>
/// <returns>Category</returns>
public Category GetCategoryById(int categoryId)
{
if (categoryId == 0)
return null;
string key = string.Format(CATEGORIES_BY_ID_KEY, categoryId);
object obj2 = _cacheManager.Get(key);
if (this.CategoriesCacheEnabled && (obj2 != null))
{
return (Category)obj2;
}
bool showHidden = NopContext.Current.IsAdmin;
var query = from c in _context.Categories
where c.CategoryId == categoryId
select c;
var category = query.SingleOrDefault();
//filter by access control list (public store)
if (category != null && !showHidden && IsCategoryAccessDenied(category))
{
category = null;
}
if (this.CategoriesCacheEnabled)
{
_cacheManager.Add(key, category);
}
return category;
}
/// <summary>
/// Gets a category breadcrumb
/// </summary>
/// <param name="categoryId">Category identifier</param>
/// <returns>Category</returns>
public List<Category> GetBreadCrumb(int categoryId)
{
var breadCrumb = new List<Category>();
var category = GetCategoryById(categoryId);
while (category != null && //category is not null
!category.Deleted && //category is not deleted
category.Published) //category is published
{
breadCrumb.Add(category);
category = category.ParentCategory;
}
breadCrumb.Reverse();
return breadCrumb;
}
/// <summary>
/// Inserts category
/// </summary>
/// <param name="category">Category</param>
public void InsertCategory(Category category)
{
if (category == null)
throw new ArgumentNullException("category");
category.Name = CommonHelper.EnsureNotNull(category.Name);
category.Name = CommonHelper.EnsureMaximumLength(category.Name, 400);
category.Description = CommonHelper.EnsureNotNull(category.Description);
category.MetaKeywords = CommonHelper.EnsureNotNull(category.MetaKeywords);
category.MetaKeywords = CommonHelper.EnsureMaximumLength(category.MetaKeywords, 400);
category.MetaDescription = CommonHelper.EnsureNotNull(category.MetaDescription);
category.MetaDescription = CommonHelper.EnsureMaximumLength(category.MetaDescription, 4000);
category.MetaTitle = CommonHelper.EnsureNotNull(category.MetaTitle);
category.MetaTitle = CommonHelper.EnsureMaximumLength(category.MetaTitle, 400);
category.SEName = CommonHelper.EnsureNotNull(category.SEName);
category.SEName = CommonHelper.EnsureMaximumLength(category.SEName, 100);
category.PriceRanges = CommonHelper.EnsureNotNull(category.PriceRanges);
category.PriceRanges = CommonHelper.EnsureMaximumLength(category.PriceRanges, 400);
_context.Categories.AddObject(category);
_context.SaveChanges();
if (this.CategoriesCacheEnabled || this.MappingsCacheEnabled)
{
_cacheManager.RemoveByPattern(CATEGORIES_PATTERN_KEY);
_cacheManager.RemoveByPattern(PRODUCTCATEGORIES_PATTERN_KEY);
}
}
/// <summary>
/// Updates the category
/// </summary>
/// <param name="category">Category</param>
public void UpdateCategory(Category category)
{
if (category == null)
throw new ArgumentNullException("category");
category.Name = CommonHelper.EnsureNotNull(category.Name);
category.Name = CommonHelper.EnsureMaximumLength(category.Name, 400);
category.Description = CommonHelper.EnsureNotNull(category.Description);
category.MetaKeywords = CommonHelper.EnsureNotNull(category.MetaKeywords);
category.MetaKeywords = CommonHelper.EnsureMaximumLength(category.MetaKeywords, 400);
category.MetaDescription = CommonHelper.EnsureNotNull(category.MetaDescription);
category.MetaDescription = CommonHelper.EnsureMaximumLength(category.MetaDescription, 4000);
category.MetaTitle = CommonHelper.EnsureNotNull(category.MetaTitle);
category.MetaTitle = CommonHelper.EnsureMaximumLength(category.MetaTitle, 400);
category.SEName = CommonHelper.EnsureNotNull(category.SEName);
category.SEName = CommonHelper.EnsureMaximumLength(category.SEName, 100);
category.PriceRanges = CommonHelper.EnsureNotNull(category.PriceRanges);
category.PriceRanges = CommonHelper.EnsureMaximumLength(category.PriceRanges, 400);
//validate category hierarchy
var parentCategory = GetCategoryById(category.ParentCategoryId);
while (parentCategory != null)
{
if (category.CategoryId == parentCategory.CategoryId)
{
category.ParentCategoryId = 0;
break;
}
parentCategory = GetCategoryById(parentCategory.ParentCategoryId);
}
if (!_context.IsAttached(category))
_context.Categories.Attach(category);
_context.SaveChanges();
if (this.CategoriesCacheEnabled || this.MappingsCacheEnabled)
{
_cacheManager.RemoveByPattern(CATEGORIES_PATTERN_KEY);
_cacheManager.RemoveByPattern(PRODUCTCATEGORIES_PATTERN_KEY);
}
}
/// <summary>
/// Gets localized category by id
/// </summary>
/// <param name="categoryLocalizedId">Localized category identifier</param>
/// <returns>Category content</returns>
public CategoryLocalized GetCategoryLocalizedById(int categoryLocalizedId)
{
if (categoryLocalizedId == 0)
return null;
var query = from cl in _context.CategoryLocalized
where cl.CategoryLocalizedId == categoryLocalizedId
select cl;
var categoryLocalized = query.SingleOrDefault();
return categoryLocalized;
}
/// <summary>
/// Gets localized category by category id
/// </summary>
/// <param name="categoryId">Category identifier</param>
/// <returns>Category content</returns>
public List<CategoryLocalized> GetCategoryLocalizedByCategoryId(int categoryId)
{
if (categoryId == 0)
return new List<CategoryLocalized>();
var query = from cl in _context.CategoryLocalized
where cl.CategoryId == categoryId
select cl;
var content = query.ToList();
return content;
}
/// <summary>
/// Gets localized category by category id and language id
/// </summary>
/// <param name="categoryId">Category identifier</param>
/// <param name="languageId">Language identifier</param>
/// <returns>Category content</returns>
public CategoryLocalized GetCategoryLocalizedByCategoryIdAndLanguageId(int categoryId, int languageId)
{
if (categoryId == 0 || languageId == 0)
return null;
var query = from cl in _context.CategoryLocalized
orderby cl.CategoryLocalizedId
where cl.CategoryId == categoryId &&
cl.LanguageId == languageId
select cl;
var categoryLocalized = query.FirstOrDefault();
return categoryLocalized;
}
/// <summary>
/// Inserts a localized category
/// </summary>
/// <param name="categoryLocalized">Localized category</param>
public void InsertCategoryLocalized(CategoryLocalized categoryLocalized)
{
if (categoryLocalized == null)
throw new ArgumentNullException("categoryLocalized");
categoryLocalized.Name = CommonHelper.EnsureNotNull(categoryLocalized.Name);
categoryLocalized.Name = CommonHelper.EnsureMaximumLength(categoryLocalized.Name, 400);
categoryLocalized.Description = CommonHelper.EnsureNotNull(categoryLocalized.Description);
categoryLocalized.MetaKeywords = CommonHelper.EnsureNotNull(categoryLocalized.MetaKeywords);
categoryLocalized.MetaKeywords = CommonHelper.EnsureMaximumLength(categoryLocalized.MetaKeywords, 400);
categoryLocalized.MetaDescription = CommonHelper.EnsureNotNull(categoryLocalized.MetaDescription);
categoryLocalized.MetaDescription = CommonHelper.EnsureMaximumLength(categoryLocalized.MetaDescription, 4000);
categoryLocalized.MetaTitle = CommonHelper.EnsureNotNull(categoryLocalized.MetaTitle);
categoryLocalized.MetaTitle = CommonHelper.EnsureMaximumLength(categoryLocalized.MetaTitle, 400);
categoryLocalized.SEName = CommonHelper.EnsureNotNull(categoryLocalized.SEName);
categoryLocalized.SEName = CommonHelper.EnsureMaximumLength(categoryLocalized.SEName, 100);
_context.CategoryLocalized.AddObject(categoryLocalized);
_context.SaveChanges();
if (this.CategoriesCacheEnabled)
{
_cacheManager.RemoveByPattern(CATEGORIES_PATTERN_KEY);
}
}
/// <summary>
/// Update a localized category
/// </summary>
/// <param name="categoryLocalized">Localized category</param>
public void UpdateCategoryLocalized(CategoryLocalized categoryLocalized)
{
if (categoryLocalized == null)
throw new ArgumentNullException("categoryLocalized");
categoryLocalized.Name = CommonHelper.EnsureNotNull(categoryLocalized.Name);
categoryLocalized.Name = CommonHelper.EnsureMaximumLength(categoryLocalized.Name, 400);
categoryLocalized.Description = CommonHelper.EnsureNotNull(categoryLocalized.Description);
categoryLocalized.MetaKeywords = CommonHelper.EnsureNotNull(categoryLocalized.MetaKeywords);
categoryLocalized.MetaKeywords = CommonHelper.EnsureMaximumLength(categoryLocalized.MetaKeywords, 400);
categoryLocalized.MetaDescription = CommonHelper.EnsureNotNull(categoryLocalized.MetaDescription);
categoryLocalized.MetaDescription = CommonHelper.EnsureMaximumLength(categoryLocalized.MetaDescription, 4000);
categoryLocalized.MetaTitle = CommonHelper.EnsureNotNull(categoryLocalized.MetaTitle);
categoryLocalized.MetaTitle = CommonHelper.EnsureMaximumLength(categoryLocalized.MetaTitle, 400);
categoryLocalized.SEName = CommonHelper.EnsureNotNull(categoryLocalized.SEName);
categoryLocalized.SEName = CommonHelper.EnsureMaximumLength(categoryLocalized.SEName, 100);
bool allFieldsAreEmpty = string.IsNullOrEmpty(categoryLocalized.Name) &&
string.IsNullOrEmpty(categoryLocalized.Description) &&
string.IsNullOrEmpty(categoryLocalized.MetaKeywords) &&
string.IsNullOrEmpty(categoryLocalized.MetaDescription) &&
string.IsNullOrEmpty(categoryLocalized.MetaTitle) &&
string.IsNullOrEmpty(categoryLocalized.SEName);
if (!_context.IsAttached(categoryLocalized))
_context.CategoryLocalized.Attach(categoryLocalized);
if (allFieldsAreEmpty)
{
//delete if all fields are empty
_context.DeleteObject(categoryLocalized);
_context.SaveChanges();
}
else
{
_context.SaveChanges();
}
if (this.CategoriesCacheEnabled)
{
_cacheManager.RemoveByPattern(CATEGORIES_PATTERN_KEY);
}
}
/// <summary>
/// Deletes a product category mapping
/// </summary>
/// <param name="productCategoryId">Product category identifier</param>
public void DeleteProductCategory(int productCategoryId)
{
if (productCategoryId == 0)
return;
var productCategory = GetProductCategoryById(productCategoryId);
if (productCategory == null)
return;
if (!_context.IsAttached(productCategory))
_context.ProductCategories.Attach(productCategory);
_context.DeleteObject(productCategory);
_context.SaveChanges();
if (this.CategoriesCacheEnabled || this.MappingsCacheEnabled)
{
_cacheManager.RemoveByPattern(CATEGORIES_PATTERN_KEY);
_cacheManager.RemoveByPattern(PRODUCTCATEGORIES_PATTERN_KEY);
}
}
/// <summary>
/// Gets product category mapping collection
/// </summary>
/// <param name="categoryId">Category identifier</param>
/// <returns>Product a category mapping collection</returns>
public List<ProductCategory> GetProductCategoriesByCategoryId(int categoryId)
{
if (categoryId == 0)
return new List<ProductCategory>();
bool showHidden = NopContext.Current.IsAdmin;
string key = string.Format(PRODUCTCATEGORIES_ALLBYCATEGORYID_KEY, showHidden, categoryId);
object obj2 = _cacheManager.Get(key);
if (this.MappingsCacheEnabled && (obj2 != null))
{
return (List<ProductCategory>)obj2;
}
var query = from pc in _context.ProductCategories
join p in _context.Products on pc.ProductId equals p.ProductId
where pc.CategoryId == categoryId &&
!p.Deleted &&
(showHidden || p.Published)
orderby pc.DisplayOrder
select pc;
var productCategories = query.ToList();
if (this.MappingsCacheEnabled)
{
_cacheManager.Add(key, productCategories);
}
return productCategories;
}
/// <summary>
/// Gets a product category mapping collection
/// </summary>
/// <param name="productId">Product identifier</param>
/// <returns>Product category mapping collection</returns>
public List<ProductCategory> GetProductCategoriesByProductId(int productId)
{
if (productId == 0)
return new List<ProductCategory>();
bool showHidden = NopContext.Current.IsAdmin;
string key = string.Format(PRODUCTCATEGORIES_ALLBYPRODUCTID_KEY, showHidden, productId);
object obj2 = _cacheManager.Get(key);
if (this.MappingsCacheEnabled && (obj2 != null))
{
return (List<ProductCategory>)obj2;
}
var query = from pc in _context.ProductCategories
join c in _context.Categories on pc.CategoryId equals c.CategoryId
where pc.ProductId == productId &&
!c.Deleted &&
(showHidden || c.Published)
orderby pc.DisplayOrder
select pc;
var productCategories = query.ToList();
if (this.MappingsCacheEnabled)
{
_cacheManager.Add(key, productCategories);
}
return productCategories;
}
/// <summary>
/// Gets a product category mapping
/// </summary>
/// <param name="productCategoryId">Product category mapping identifier</param>
/// <returns>Product category mapping</returns>
public ProductCategory GetProductCategoryById(int productCategoryId)
{
if (productCategoryId == 0)
return null;
string key = string.Format(PRODUCTCATEGORIES_BY_ID_KEY, productCategoryId);
object obj2 = _cacheManager.Get(key);
if (this.MappingsCacheEnabled && (obj2 != null))
{
return (ProductCategory)obj2;
}
var query = from pc in _context.ProductCategories
where pc.ProductCategoryId == productCategoryId
select pc;
var productCategory = query.SingleOrDefault();
if (this.MappingsCa
