CS0108 Warnings when Compiling code

9 mesi tempo fa
Hi,

I am getting the following two Warnings when I compile NopCommerce version 4.7:
```
warning CS0108: 'checkVatPortTypeClient.CloseAsync()' hides inherited member 'ClientBase<checkVatPortType>.CloseAsync()'. Use the new keyword if hiding was intended.

warning CS0618: 'ImageExtensions.Image(IContainer, byte[], ImageScaling)' is obsolete: 'This element has been changed since version 2023.5. Please use the Image method overload that returns the ImageDescriptor object.'
```
Is there a plan to upgrade the code in the very near future, or can I make some local adjustments to fix it directly?
9 mesi tempo fa
webzest wrote:
...Is there a plan to upgrade the code in the very near future, or can I make some local adjustments to fix it directly?


Major release are 1 - 2 per year.  4.70 was released end of April
Minor releases are bug fixes.  There is no set schedule for those.
The release notes show:
Release Notes - nopCommerce 4.70.0 (April 26th, 2024)
#7034 Fix build warnings CS0108 and CS0618

So, are you really running 4.70, or are you using some pre-release?
9 mesi tempo fa
This is the version that is listed on the Nop.Web Properties page:

    <TargetFramework>net8.0</TargetFramework>
    <Copyright>Copyright © Nop Solutions, Ltd</Copyright>
    <Company>Nop Solutions, Ltd</Company>
    <Authors>Nop Solutions, Ltd</Authors>
    <Version>4.70.0</Version>
9 mesi tempo fa
They always bump up the version when starting work on it.
Example - 4.80

Did you get your source code from the release package or from GitHub?
9 mesi tempo fa
Hi. I don't see the second warning in the latest builds.But as for the warning:

warning CS0108: 'checkVatPortTypeClient.CloseAsync()' hides inherited member 'ClientBase<checkVatPortType>.CloseAsync()'. Use the new keyword if hiding was intended.


Then it will remain for now. This is due to the fact that the checkVatPortType calas is generated automatically based on the description and it is not rational to make changes to it.