NopCommerce 4.10 - High memory usage and how we've handled it

This code update has dramatically changed the speed of our site.

Google PageSpeed Insights score went from 36% to 96%

Good work!

Work well. Thank you.

Ok, I can just say wow.

With the core code correction I wen't from 4 minutes to instant. Just images taking time to load.

So i'm very happy. Congratulations!

I will test 1k product with tier price on same page in Christmas time. I will keep you posted.

http://www.foxnetsoft.com/content/files/Nop.Web.Framework.dll.zip

This is compiled DLL file.

a.m. wrote:

Hi Andrei,

The fix you made makes sense only if you use EF Core 2.1 as in the new version of EF Core 2.2 it will be fixed and I guess nopCommerce 4.20 will use the new version anyway so the fix will no longer be needed in 4.20.

Wouldn't it be better if you add the fix to the official nopCommerce 4.10 source code and update the NoSourceCode version with the fix as well?

Some store owners are not technically savvy and will have difficulties applying the fix themselves.
Also many store owners don't read the forums and they have no idea that such an issue exists and usually come to us with questions like "Do you know why nopCommerce 4.10 is slower than 3.90?" etc.

I know you usually don't update the official versions of nopCommerce once they are released but in this case your fix is a quite simple change and it is NOT a breaking change. I also don't think it will break any of our existing code for example plugins etc. but at the same time it will resolve so many performance issues in nopCommerce 4.10 out of the box.

Thanks,
Boyko

EF Core 2.2 has this fix.
EF Core team changed some of kernel code in EF Core 2.2.
I didn't investigate it. But this bug was marked 'Solved'.

foxnetsoft wrote:

Hi foxnetsoft,

Yes, it is already fixed.
The fix is pretty much what Andrei already did in his fix to set AutoDetectChangesEnabled to false.

Thanks,
Boyko

So, what should I do to fix EF Core 2.1 problem in my current Nopcommerce 4.10 projects? I tried to change code, but I couldn't find a file "NopLazyLoader.cs"

I downloaded source code both from
offical page: https://www.nopcommerce.com/downloads.aspx
github: (https://github.com/nopSolutions/nopCommerce/archive/develop.zip)
and pulled from git command.

But there is no such a file.

I have just updated EF Core from 2.1 to 2.1.4. Does it helpful for performance problem?

I gave URL for new compiled DLL file.
Replace it and try.

a.m. wrote:
Thanks Andrei,
I applied this fix directly to the source, recompiled and applied to my site. What a major improvement.
Greg