Minor changes request for nopCommerce 3.90

Hello Andrei,

over the last few months I found a few minor flaws in the store which I guess can be fixed in 3.90.


1. "Accept Privacy Policy" alert message on registration page is still shown as a basic JS alert window. Since 3.80, all other alert messages throughout the site are using the "UI dialog" popup, so perhaps you should change this one too.


2. The "image squares" attributes need an additional class name that will allow us to distinguish them from plain color squares, something like this:

<ul class="option-list color-squares image-squares"> ...

Currently they have only the option-list and color-squares class names which is sometimes not enough.


3. "Add to wishlist" button in product boxes on catalog pages and the same button in the "overview" panel on product pages are sharing the same text resource, while the "Add to compare list" buttons are not - the latter are using different txt resources in both cases. I think it is a good idea to separate the txt resource for the wishlist buttons too, not only for consistency but also for example if someone needs to write a shorter text only for the button inside the catalog boxes, where the space available is much less than on the product page - e.g. "wishlist" / "add to wishlist".


4. The default "click-to-zoom" behaviour in the product picture gallery is a bit strange - there is this setting mediasettings.defaultpicturezoomenabled which allows or disallows the click-to-zoom functionality for the main product picture, but the thumbnails are unaffected, they always zoom on click. Usually most users will expect the thumbnail (when clicked) to switch the main image above, and only the main image to zoom (when clicked). Perhaps this can be optimized in NopCommerce too.


Best Regards
/ Hristo

Hey Hristo,

Thanks a lot! I've just created four tasks (one, two, three, four)

Thanks a lot Andrei, for spending some time on these issues.

But there is an misunderstanding about the image square attributes. As written above, the idea was to have an additional class name, not a class name that will replace the old one. The old class name is needed too ("color-squares"), because these attributes are color-squares, just a bit different. Without the old class name we have to write the same css styling twice - once for color squares and then again for image squares This is not an optimal solution at all. Please return the old class name together with the new one, like this:

<ul class="option-list color-squares image-squares" ... >

Also I noticed you have changed the class names of the inner elements too ("color-container" and "color")... Same problem here, please return the old class names together with the new ones (like this: "color-container image-container" and "color image").


Another potential problem I noticed is in the changed "picture-thumbs" elements in the picture gallery on product page. Until now the thumbnails were "inline" level elements (<a></a>). Now they are "block" level elements (<div></div>). Please revert them to <a></a> to avoid possible conflicts with existing zoom plugins for nopCommerce, etc.


We really hope these two problems could be fixed.


Best regards
/ Hristo

Hi Hristo,

Sure. I've just re-opened the work item

Hello Andrei,

While I was working with the new Customer Enters Quantity functionality in nopCommerce 3.90 I came up with a small issue. The <div> that is holding the label and the textbox doesn't have a class name. This will make it difficult to be styled with CSS. Maybe you should consider adding a unique class for the Quantity Box.

Thank you for the time,
Nikola.

Hi Nikola,


Sure. We'll do it soon (work item)

Thanks!

Hi Hristo

we decided not to use <a> for product thumbnails because it is unnecessary anymore. It made sense to use them before because of magnificPopup plugin, but not now. If we leave <a> with empty src instead of <div> it will be unclear for developers.

We also added a common "attribute-squares" class. Have a look: changeset.

Hello,

it seems you forgot to merge the new "attribute-squares" markup into the specification table and compare-products table. Now we have two different versions of the markup for the same thing on different pages.

Please fix this.

Regards
/ Hristo