Question about recent changes in "Contact Us" page

This topic was automatically closed 365 days after the last reply. New replies are no longer allowed.
5 years ago
Hello nopCommerce team.

In this 4.2 commit you have modified the "Contact Us" page:

https://github.com/nopSolutions/nopCommerce/commit/0cc0a73d6dadddf7d7f16e5387e2d1cd3125882e

The commit description says "Remove duplicate page title".
Actually there was no duplicated page title, until now there was one page title, and one topic-block title. On the demo they both had the same text ("Contact Us"), but they were not the same thing.

If one of these should go away, it is definitely not the page title - the topic title has a different html structure and will not inherit any "page title" css styles from the site. Some themes use a big amount of custom styling for page titles with banners below the text etc. and in these themes the page will appear half empty now, after your change.

Please reconsider this change, all pages need a page title, if you still need to remove one of the two elements (but why, they are not the same), you can remove the topic title, and not the page title.


Regards
/ Hristo
5 years ago
Hi Hristo,

You're absolutely right. I've just created a work item
4 years ago
Hi Hristo,

Done (commit)
This topic was automatically closed 365 days after the last reply. New replies are no longer allowed.