One thing I am thinking is, DependencyRegistrar gets called only on App Starts. That means it's called once per application pool recycle. And as far as I can see, uninstalling plugins doesn't restart apps, which means it won't work like how you want it to even if you write it inside DependencyRegistrar. Unless I am missing anything, I think writing inside the method is needed.
So your method will check if plugin is installed: if yes, run code; if not, call the original nopCommerce interface / method.
:P
Uninstalled plugin still being used
- 43
- 515
- 03/06/2010
- United States
Try this in DependencyRegistrar
hope this makes it easier.
var pluginFinder= new PluginFinder();
pluginFinder.ReloadPlugins();
var pluginDescriptor = pluginFinder.GetPluginDescriptorBySystemName("Nop.MyPlugin");
if (pluginDescriptor!=null)
{
builder.RegisterType<MyPluginService>().As<IPriceCalculationService>().InstancePerRequest();
}
hope this makes it easier.
- 6
- 30
- 12/10/2016
- Netherlands
Not sure if this is still relevant, but here is a sollution:
You can use this in the Register method to check if the plugin is installed:
You can use this in the Register method to check if the plugin is installed:
// Is this plugin installed??
var isInstalled = false;
var types = typeFinder.FindClassesOfType<IPluginFinder>(true);
if (types.Count() == 1)
{
var plugins = Activator.CreateInstance(types.First()) as IPluginFinder;
var plug = plugins.GetPluginDescriptorBySystemName("Miscellaneous.plugin");
if (plug != null && plug.Installed)
{
isInstalled = true;
}
}
- 24
- 178
- 16/01/2017
- United States
henksalomons wrote:
I elaborated a bit on this to fit my needs, others may find it universally helpful.
Then in my DependencyRegistrar's Register function:
Not sure if this is still relevant, but here is a sollution:
You can use this in the Register method to check if the plugin is installed:
You can use this in the Register method to check if the plugin is installed:
// Is this plugin installed??
var isInstalled = false;
var types = typeFinder.FindClassesOfType<IPluginFinder>(true);
if (types.Count() == 1)
{
var plugins = Activator.CreateInstance(types.First()) as IPluginFinder;
var plug = plugins.GetPluginDescriptorBySystemName("Miscellaneous.plugin");
if (plug != null && plug.Installed)
{
isInstalled = true;
}
}
I elaborated a bit on this to fit my needs, others may find it universally helpful.
private static bool IsPluginInstalled(ITypeFinder typeFinder)
{
var isInstalled = false;
var types = typeFinder.FindClassesOfType<IPluginFinder>(true).ToList();
if (types.Count() != 1) return false;
var plugins = Activator.CreateInstance(types.First()) as IPluginFinder;
var thisPlugin = GetPluginInfo();
if (thisPlugin == null) return false;
var plug = plugins?.GetPluginDescriptorBySystemName(thisPlugin.SystemName);
if (plug != null && plug.Installed)
isInstalled = true;
return isInstalled;
}
private static PluginDescriptor GetPluginInfo()
{
try
{
var pluginFullName = System.Reflection.Assembly.GetExecutingAssembly().GetName().Name;
var pluginShortName = pluginFullName.Replace("Nop.Plugin.", string.Empty);
var json = File.ReadAllText($"Plugins/{pluginShortName}/plugin.json");
var descr = JsonConvert.DeserializeObject<PluginDescriptor>(json);
return descr;
}
catch (Exception e)
{
if (Debugger.IsAttached)
Console.WriteLine(e);
throw;
}
}
Then in my DependencyRegistrar's Register function:
var installed = IsPluginInstalled(typeFinder);
if (!installed) return;
...
- 39
- 253
- 25/11/2009
- Iran (Islamic Republic of)
henksalomons wrote:
Hi everybody.
Unfortunately, this code can't work in nop version 4.10,because we must add one instanse of IEventpublisher to the Activator.CreateInstance,as below:
But the point is, how to initialize event publisher in this section!?
Thanks.
Not sure if this is still relevant, but here is a sollution:
You can use this in the Register method to check if the plugin is installed:
You can use this in the Register method to check if the plugin is installed:
// Is this plugin installed??
var isInstalled = false;
var types = typeFinder.FindClassesOfType<IPluginFinder>(true);
if (types.Count() == 1)
{
var plugins = Activator.CreateInstance(types.First()) as IPluginFinder;
var plug = plugins.GetPluginDescriptorBySystemName("Miscellaneous.plugin");
if (plug != null && plug.Installed)
{
isInstalled = true;
}
}
Hi everybody.
Unfortunately, this code can't work in nop version 4.10,because we must add one instanse of IEventpublisher to the Activator.CreateInstance,as below:
var plugins = Activator.CreateInstance(types.First(), eventPublisher) as IPluginFinder;
But the point is, how to initialize event publisher in this section!?
Thanks.
- 39
- 253
- 25/11/2009
- Iran (Islamic Republic of)
This method of answer can give:
var subscriptionService = new SubscriptionService();
var eventPublisher = new EventPublisher(subscriptionService);
var types = typeFinder.FindClassesOfType<IPluginFinder>();
var enumerable = types as Type[] ?? types.ToArray();
if (enumerable.Count() == 1)
{
if (Activator.CreateInstance(enumerable.First(), eventPublisher) is IPluginFinder pluginFinder)
{
var currentPlugin = pluginFinder.GetPluginDescriptorBySystemName("misc.myplugin");
if (currentPlugin == null || currentPlugin.Installed == false)
return;
}
}
- 24
- 178
- 16/01/2017
- United States
Updated with complete code for nop 4.1:
private static bool IsPluginInstalled(ITypeFinder typeFinder)
{
var thisPlugin = GetPluginInfo();
if (thisPlugin == null) return false;
var subscriptionService = new SubscriptionService();
var eventPublisher = new EventPublisher(subscriptionService);
var types = typeFinder.FindClassesOfType<IPluginFinder>();
var enumerable = types as Type[] ?? types.ToArray();
if (enumerable.Count() != 1) return false;
if (!(Activator.CreateInstance(enumerable.First(), eventPublisher) is IPluginFinder pluginFinder))
return false;
var currentPlugin = pluginFinder.GetPluginDescriptorBySystemName(thisPlugin.SystemName);
return currentPlugin != null && currentPlugin.Installed;
}
private static PluginDescriptor GetPluginInfo()
{
try
{
var pluginFullName = System.Reflection.Assembly.GetExecutingAssembly().GetName().Name;
var pluginShortName = pluginFullName.Replace("Nop.Plugin.", string.Empty);
var json = File.ReadAllText($"Plugins/{pluginShortName}/plugin.json");
var descr = JsonConvert.DeserializeObject<PluginDescriptor>(json);
return descr;
}
catch (Exception e)
{
if (Debugger.IsAttached)
Console.WriteLine(e);
throw;
}
}
