PictureService uses HttpContext.Current, risk of NullReferenceException

In nop 2.1, the properties LocalThumbImagePath and LocalImagePath both call HttpContext.Current to get the physical path. However, if the picture service is used in for instance a task, HttpContext.Current is null and getting the physical path will throw a NullReferenceException. A better way to do this is to call HttpRuntime.AppDomainAppPath

Thanks!

This problem is still there in nop 2.3. It doesn't throw NullReferenceException but NotImplementedException

Thanks for info. I'll create a work item

[email protected] wrote:
Just found that HttpRuntime.AppDomainAppPath cannot be used in unit tests. I think it should be wrapper to some class, such as IWebHelper.

See changeset de44d5f7de13. Please let me know if it works fine now

a.m. wrote:
Seems to work now, thanks a lot!