Is the discount architecture really robust?

This topic was automatically closed 365 days after the last reply. New replies are no longer allowed.
11 years ago
Hello,
I'm using NC 1.90 and having some problems with the management of discounts.
I wanted to see how latest versions would run them and hoped to see something new.
And I'm pretty disappointed, I still see methods that I find personally "strange".
Example: GetDiscountByCouponCode which executes GetAllDiscounts(null, ...) and searches in the results.
Is it really optimized concerning database calls?
Tell me if I'm wrong, but I feel like I do a SELECT with no WHERE clause (or almost) and get - I don't know - 10, 100, 10 000 (why not?) discounts and then search for "MYCOUPONCODE" in it. A syntax which implies a direct SQL query with something like "WHERE CouponCode = 'MYCOUPONCODE'" would be better. What do you think?
Best regards.
11 years ago
https://www.nopcommerce.com/boards/t/18705/suggestion-a-simple-way-to-generate-massive-and-personalized-discount-coupons.aspx
11 years ago
Sure. Thanks a lot. Almost forgot about it. It'll be fixed in the near time
11 years ago
Done. Please see changeset fb4ed58ff51e
11 years ago
Great! Thank you for this concern.
This topic was automatically closed 365 days after the last reply. New replies are no longer allowed.