Hi
We have developed the Payment Gateway plugin for Nopcommerce 4.2 and the uptake has been pretty good for this plugin.
We have updated the plugin for Nopcommerce 4.3 but have picked up the following bug with Nopcommerce 4.3 RC.
The updated plugin installs successfully in Nopcommerce 4.3, but when you check out and get redirected to the payment gateway you get the following error message:
Synchronous operations are disallowed. Call WriteAsync or set AllowSynchronousIO to true instead.
The only way to fix this is to add some additional code in the startup.cs file located in the source code version under Presentation/Nop.Web folder.
The additional code is as follows:
using Microsoft.AspNetCore.Server.Kestrel.Core;
and
services.Configure<IISServerOptions>(options =>
{
options.AllowSynchronousIO = true;
});
}
The full Startup.cs code then looks like below:
using Autofac;
using Microsoft.AspNetCore.Builder;
using Microsoft.AspNetCore.Hosting;
using Microsoft.AspNetCore.Server.Kestrel.Core;
using Microsoft.Extensions.Configuration;
using Microsoft.Extensions.DependencyInjection;
using Nop.Core.Configuration;
using Nop.Core.Infrastructure;
using Nop.Web.Framework.Infrastructure.Extensions;
namespace Nop.Web
{
/// <summary>
/// Represents startup class of application
/// </summary>
public class Startup
{
#region Fields
private readonly IConfiguration _configuration;
private readonly IWebHostEnvironment _webHostEnvironment;
private IEngine _engine;
private NopConfig _nopConfig;
#endregion
#region Ctor
public Startup(IConfiguration configuration, IWebHostEnvironment webHostEnvironment)
{
_configuration = configuration;
_webHostEnvironment = webHostEnvironment;
}
#endregion
/// <summary>
/// Add services to the application and configure service provider
/// </summary>
/// <param name="services">Collection of service descriptors</param>
public void ConfigureServices(IServiceCollection services)
{
(_engine, _nopConfig) = services.ConfigureApplicationServices(_configuration, _webHostEnvironment);
//Patch for allowing synchronous method required by some Payment Gateways
services.Configure<IISServerOptions>(options =>
{
options.AllowSynchronousIO = true;
});
}
public void ConfigureContainer(ContainerBuilder builder)
{
_engine.RegisterDependencies(builder, _nopConfig);
}
/// <summary>
/// Configure the application HTTP request pipeline
/// </summary>
/// <param name="application">Builder for configuring an application's request pipeline</param>
public void Configure(IApplicationBuilder application)
{
application.ConfigureRequestPipeline();
application.StartEngine();
}
}
}
Is it possible for this to be included in the final Source and no source version of Nopcommerce 4.3, otherwise we will not be able to provide this plugin to customers.
Trusting for a positive response as I am sure there will be other Payment gateway plugins also affected if this change is not implemented.
regards
Philip
