nopCommerce 4.0 - Bug fixes and improvements

Nop-Templates.com wrote:

I think this will help

Nop-Templates.com wrote:

Thanks for the suggestion and contribution. We removed global MVC exception filter and diagnostic listener. Now exception errors are logged using the way you proposed. You can see the changes here.

Hi,

The "Double" editor template is not working. The double.MinValue and double.MaxValue are not correctly encoded because of the "+" symbol. Please see the attached screenshot.



Regards,
Stoyan

Hi Andrei,

In some of our plugins, we have the need to resolve certain controllers. In 3.90 we are doing it like this:

var someController = DependencyResolver.Current.GetService(typeof(SomeController)) as SomeController;

and this is working perfectly because the controllers are registered in the dependency container via this code: builder.RegisterControllers(typeFinder.GetAssemblies().ToArray());

However, in 4.00 the controllers are not registered in the dependency container anymore and we cannot resolve them.

Adding the controllers into DC is easy, you just have to chain-call the ".AddControllersAsServices()" method after services.AddMvc() on line 223 ServiceCollectionExtensions file and voila - the controllers are added successfully to the DC. However, there is one big problem with this - for some unknown reason the HttpContext is always null and this is causing a lot of troubles. For example, using RenderViewComponentToString method will throw an exception on this line - HttpContext.RequestServices.GetService(typeof(IActionContextAccessor)) as IActionContextAccessor; as the HttpContext is null. Most probably some other methods like RenderPartialViewToString that are using the HttpContext will throw the same exception.

Do you think you can find a solution for this for 4.00?

Regards,
Hristian

RomanovM wrote:

Hi Romanov,

I just sent you a PM with the sample package.

p.s: I also included a sample theme package in case you would like to enhance the functionality with theme support as suggest here.

Thanks,
Boyko

RomanovM wrote:

Hi Romanov,

Thank you very much!
It looks good but I will let you know if there are any problems after I give it a try a bit later.

Many thanks again!

Boyko

Nop-Templates.com wrote:
Are trying to use it in admin area or public store? Are you using the culture is set to en-US (always set in admin area for formatting)? Do you experience it for other pages (e.g. product details page in admin area)?

When I look at the generated HTML, then I see something like:

$(document).ready(function() {
        $("#OverriddenGiftCardAmount").TouchSpin({
            min: -79228162514264337593543950335,
            max: 79228162514264337593543950335,
            decimals: 4, //always display 4 digits
            forcestepdivisibility: "none",
            verticalbuttons: true,
            postfix: ""
        });
    });

Please note that it was implemented absolutely the same way in 3.90.

Nop-Templates.com wrote:
Hi Hristian,

You can use EngineContext.Current.ResolveUnregistered(typeof(SomeController)). But the issue with "HttpContext" could be resolved maybe only injecting IHttpContextAccessor. Anyway, other "Context properties" won't be intialized (not sure that you need them). So they should be a better approach to "Contextualize" resolved controllers

Nop-Templates.com wrote:

Hi Romanov,

Since I upgraded to the latest version (it may be just coincidence) I get some very strange behavior when I receive an exception i.e component name is wrong or when a component returns a named view that does not exist.
Instead of getting the developer friendly exception page with the error I get this:

"502.3 bad gateway"

The exception is also not logged in the Log. I believe it is something on my machine i.e the aspdotnet core iis module but need to be sure it is just me.

Do you experience such a strange behavior?

Thanks,
Boyko

a.m. wrote:

Hi Andrei,

This is happening in the Admin area. I believe you have tested the "Decimal" editor template. There is a problem only with the "Double" template. Since the "Double" template is not used in the administration you can test by modifying the "Decimal" template and open the product edit page. Just change the min and max parameters of the Decimal template to:
  min: @(double.MinValue)
  max: @(double.MaxValue)

In 3.9 implementation is the same but it is working correctly.

Regards,
Stoyan